Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hash_many in sector_roots #53

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Use hash_many in sector_roots #53

merged 2 commits into from
Oct 2, 2024

Conversation

ChrisSchinnerl
Copy link
Member

This got me another 20% speed improvement over the benchmark in the last PR.

sector_root             time:   [2.1680 ms 2.1759 ms 2.1842 ms]
                        change: [-1.1522% -0.5397% +0.0751%] (p = 0.08 > 0.05)
                        No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/sector-root-hash-many branch 2 times, most recently from bbd64c3 to b639e10 Compare September 28, 2024 12:21
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review September 28, 2024 12:23
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/sector-root-hash-many branch 3 times, most recently from a8915c6 to f482712 Compare September 28, 2024 12:30
lukechampine
lukechampine reviewed Sep 28, 2024
View reviewed changes
src/rhp.rs
// hash them
let mut jobs = [
HashManyJob::new(&params, &inputs[0][..]),
HashManyJob::new(&params, &inputs[1][..]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. It seems like you're iterating over groups of 4 segments at a time, but here you're only hashing 2 of them? 🤔

@ChrisSchinnerl ChrisSchinnerl self-assigned this Oct 2, 2024
@n8maninger n8maninger merged commit 3f66b7b into master Oct 2, 2024
1 check passed
@n8maninger n8maninger deleted the chris/sector-root-hash-many branch October 2, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukechampine lukechampine lukechampine left review comments

@n8maninger n8maninger n8maninger approved these changes

Assignees

@ChrisSchinnerl ChrisSchinnerl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisSchinnerl @lukechampine @n8maninger